feat: Add Socat container implementation#1416
Merged
HofmeisterAn merged 6 commits intodevelopfrom Apr 3, 2025
Merged
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
HofmeisterAn
approved these changes
Apr 3, 2025
Collaborator
HofmeisterAn
left a comment
HofmeisterAn
left a comment
There was a problem hiding this comment.
Hey Eddú, thanks for the PR. While reviewing, I noticed two issues. One of them seems like a bug we hadn't caught before.
- Usually, the builders don't need to handle merging any values. That's automatically done by the underlying implementation. It looks like a constraint prevented that for the
SocatConfigurationclass. See my changes inBuildConfiguration. - I think we can remove exposing the port
8080for the hello world container. I think all traffic should go through Socat and the Docker network.
If you're good with these changes, I'm happy to merge the PR.
Collaborator
|
It looks like there is an issue pulling images from icr.io, probably a temporary issue. |
HofmeisterAn
changed the title
Member
Author
|
Hi @HofmeisterAn, thank you so much for all the improvements! learned so much by submitting this PR. 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds an utility
SocatContainerthat can serve as a proxy to other containers.Why is it important?
Related issues
N/A